From: Jeff King <peff@peff.net>
Date: Thu, 24 Nov 2022 01:11:38 GMT
Subject: Re: [PATCH v5 0/3] git-jump: support Emacs
Message-ID: <Y37Eyqxrrfe5OkTY@coredump.intra.peff.net>
In-Reply-To: <pull.1423.v5.git.1669187053.gitgitgadget@gmail.com>

On Wed, Nov 23, 2022 at 07:04:10AM +0000, Yoichi NAKAYAMA via GitGitGadget wrote:

> Add an optional argument 'stdout' to print the quickfix lines to standard
> output. It can be used with M-x grep on Emacs.
> 
> Detect emacsclient by GIT_EDITOR and invoke the function. Tested with
> EDITOR="emacsclient" and EDITOR="emacsclient -t".

Thanks, this version looks fine to me. I see your response to Phillip
may result in a v6 where the loop within the emacs code is moved, but I
have no opinion on that. :) So assuming that is the only change, my
review will still stand.

-Peff