From: Taylor Blau <me@ttaylorr.com>
Date: Fri, 04 Nov 2022 22:13:12 GMT
Subject: Re: [PATCH v3 0/2] pack-bitmap.c: avoid exposing absolute paths
Message-ID: <Y2WOeClE+E8C0hiP@nand.local>
In-Reply-To: <cover.1667470481.git.dyroneteng@gmail.com>

On Fri, Nov 04, 2022 at 11:17:08AM +0800, Teng Long wrote:
> From: Teng Long <dyroneteng@gmail.com>
>
> Diff since v2:
>
> 1. trace2 log will include the path info of pack. not only "basename".
> 2. A new commit which removes unnecessary "open_pack_index()" calls in
> "open_midx_bitmap_1()".
> 3. The patch v2 still base on 2.37, rebase on 'master' to prevent conflicts.
>
> Thanks.

This version is looking pretty good, and I very much appreciate the
rebase onto 'master' in the meantime.

I left a couple of notes throughout which I think merit a small reroll.
Otherwise, this is looking just about ready to go.


Thanks,
Taylor