From: Jeff King <peff@peff.net>
Date: Fri, 04 Nov 2022 12:55:21 GMT
Subject: Re: [PATCH 2/3] bisect--helper: move all subcommands into their own functions
Message-ID: <Y2ULud3Cladlz2rZ@coredump.intra.peff.net>
In-Reply-To: <081f3f7f9501012404fb9e59ab6d94f632180b53.1667561761.git.congdanhqx@gmail.com>

On Fri, Nov 04, 2022 at 06:40:11PM +0700, Đoàn Trần Công Danh wrote:

> In a later change, we will use OPT_SUBCOMMAND to parse sub-commands to
> avoid consuming non-option opts.
> 
> Since OPT_SUBCOMMAND needs a function pointer to operate,
> let's move it now.

Makes sense, and splitting this into its own step makes it easier to
verify.

> +static int cmd_bisect__reset(int argc, const char **argv, const char *prefix UNUSED)

Thank you very much for putting the UNUSED markers here. It will save me
the trouble of handling it on my topic. :)

-Peff