From: Taylor Blau <me@ttaylorr.com>
Date: Fri, 28 Oct 2022 19:54:40 GMT
Subject: Re: [PATCH v2 0/2] Implement filtering repacks
Message-ID: <Y1wzgOTiKdBcBba0@nand.local>
In-Reply-To: <20221025122856.20204-1-christian.couder@gmail.com>

On Tue, Oct 25, 2022 at 02:28:54PM +0200, Christian Couder wrote:
> So there are only 2 patches now in this v2 series:
>
>   - Patch 1/2 is a preparatory patch.
>
>   - Patch 2/2 introduces the `--filter=<filter-spec>` option.

One thing that I wasn't clear on in this or the previous round(s) was
how we handle setting remote.<name>.promisor and partialclonefilter.

If there is a single remote, then it's obvious that we should set
promisor to "true" and partialCloneFilter to whatever value of
`--filter` the user provided when repacking / GCing.

But what happens if there are multiple remotes? Which get the new
configuration settings modified?

I wonder what breakage happens if we fail to do that (and why such
breakage isn't yet noticed by CI).

Thanks,
Taylor