From: Jeff King <peff@peff.net>
Date: Tue, 11 Oct 2022 00:23:44 GMT
Subject: Re: [PATCH 4alt/4] attr: drop DEBUG_ATTR code
Message-ID: <Y0S3kKVm0jYxEXc1@coredump.intra.peff.net>
In-Reply-To: <xmqqwn9clwba.fsf@gitster.g>

On Thu, Oct 06, 2022 at 10:02:33AM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > On Thu, Oct 06, 2022 at 09:13:41AM -0400, Jeff King wrote:
> >
> >> The other obvious option is to just delete this debug code, and remove
> >> the unused parameter. I'm not sure if the trace would ever be useful or
> >> not, and I am mostly retaining it out of the logic of "well, somebody
> >> bothered to write it". I think the const issue has been there since
> >> e810e06357 (attr: tighten const correctness with git_attr and
> >> match_attr, 2017-01-27).
> >
> > And here's what that would look like.
> 
> I highly suspect that I was the one who bothered, and while I admit
> it was useful while developing the attribute subsystem, I haven't
> needed it for the past 10 or so years.

It was indeed you. :) I am quite happy to delete the code (via 4alt),
but didn't want to step on any toes.

-Peff