From: Taylor Blau <me@ttaylorr.com>
Date: Mon, 10 Oct 2022 19:00:34 GMT
Subject: Re: [PATCH] log: require --grep for --invert-grep and --all-match, fix segfault
Message-ID: <Y0Rr0sQ91C/SgmBJ@nand.local>
In-Reply-To: <221010.86o7ujpl44.gmgdl@evledraar.gmail.com>

On Mon, Oct 10, 2022 at 08:48:25PM +0200, Ævar Arnfjörð Bjarmason wrote:
> The rationale for changing it this way is that the documentaion says:
>
> 	--all-match::
> 	        Limit the commits output to ones that match all given `--grep`,
> 	        instead of ones that match at least one.
> 	--invert-grep::
> 	        Limit the commits output to ones with log message that do not
> 	        match the pattern specified with `--grep=<pattern>`.

This does feel a little academic, but to me the documentation seems to
suggest that `--all-match` or `--invert-grep` should both support the
absence of a `--grep` argument.

At least in `--invert-grep`, my reading is "the pattern specified with
`--grep=<pattern>` [...if any]".

In any case, the behavior has been as such for long enough that it feels
like our documentation needs to be changed, and not the behavior itself.
On the other hand, I have a hard time imagining that many/any people
care about this particular behavior.

Thanks,
Taylor