From: Joey Salazar <jgsal@protonmail.com>
Date: Tue, 27 Oct 2020 00:04:35 GMT
Subject: Re: [OUTREACHY][PATCH v2] t7006: Use test_path_is_* functions in test script
Message-ID: <XDwhHkxbkjL46BTp1WCJ5gJ3UbrMxRGwR2VgeRxehZh0-G07JlxCHrBGCpruqk-OegVspO6LJ0Y3yW9izl97pufYDwOhGaS885_xaVK63vs=@protonmail.com>
In-Reply-To: <AwF-WVCPGK9qyy3lWQ-aYXuvw7HTPjjGuvT4rbPjgoWZE0czToIU-aACj2oyRnkOevGWLQbDgtndt9dkMSGF-SFkNanPgao9yLuVYU1VURI=@protonmail.com>


On Monday, October 26, 2020 5:00 PM, Joey Salazar <jgsal@protonmail.com> wrote:

> For instances when `${if_local_config}` is either '' or '! ' then
> `test_path_is_file` will diagnose the directory and print a message if
> and only if the result `is false` goes away.
>
If `if test -n '$pager_wanted'` is checking if pager_wanted=true before diagnosing core.pager_used, then would;

For other instances when '$pager_wanted' is not empty then `test_path_is_file`
will diagnose the directory and print a message.

be more accurate?