From: Taylor Blau Date: Tue, 01 Dec 2020 23:43:25 GMT Subject: Re: [PATCH v2 00/24] pack-bitmap: bitmap generation improvements Message-ID: In-Reply-To: <20201201233725.3396453-1-jonathantanmy@google.com> On Tue, Dec 01, 2020 at 03:37:25PM -0800, Jonathan Tan wrote: > > Once we can reach a good decision there, I'll send a v3 (which currently > > lives in my fork[2]). > > I did, but Stolee has a point that the algorithm will change later on. > I'm OK with the parts I reviewed (patches 10 to 18). Ah, good to know. I'll hold off on a v3, then, until you have had a chance to look through the remaining handful of patches (if you were planning on doing that). I haven't touched those locally, so it'll be good to hear any comments you might have before sending another version. Thanks for all of your very helpful review :-). Taylor