From: Taylor Blau <me@ttaylorr.com>
Date: Tue, 01 Dec 2020 18:34:31 GMT
Subject: Re: [PATCH v2] builtin/bugreport.c: use thread-safe localtime_r()
Message-ID: <X8aMt2LEiCLkdV9/@nand.local>
In-Reply-To: <xmqqlfehqt4n.fsf@gitster.c.googlers.com>

On Tue, Dec 01, 2020 at 10:27:20AM -0800, Junio C Hamano wrote:
> I am not opposed to banning ctime_r() and asctime_r(), but I do not
> want to see our future readers wonder why they are banned by the
> commit whose title clearly states that we refuse non-reentrant ones
> in our codebase.

Agreed. Maybe splitting these into two (one to ban non-reentrant
functions, and another to ban ctime_r() and asctime_r()) would help.

Thanks,
Taylor