From: Simon Ruderich <simon@ruderich.org>
Date: Sun, 10 Jan 2021 20:31:18 GMT
Subject: Re: [PATCH v3 2/2] refs: allow @{n} to work with n-sized reflog
Message-ID: <X/tkFuESnia/n35e@ruderich.org>
In-Reply-To: <c88c997eab2b3405cce20f719bf07d5bba7aa18e.1610015769.git.liu.denton@gmail.com>

On Thu, Jan 07, 2021 at 02:36:59AM -0800, Denton Liu wrote:
> diff --git a/refs.c b/refs.c
> index bfdd04aefd..e70dcd33f7 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -900,40 +900,53 @@ static int read_ref_at_ent(struct object_id *ooid, struct object_id *noid,
>  		const char *message, void *cb_data)
>  {
>  	struct read_ref_at_cb *cb = cb_data;
> +	int reached_count;
>
>  	cb->tz = tz;
>  	cb->date = timestamp;
>
> -	if (timestamp <= cb->at_time || cb->cnt == 0) {
> +	/*
> +	 * It is not possible for cb->cnt == 0 on the first itertion because

s/itertion/iteration/

Regards
Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9