From: Brandon Casey Date: Thu, 06 Oct 2011 18:22:23 GMT Subject: [PATCH v3 3/5] builtin/mv.c: plug miniscule memory leak Message-ID: In-Reply-To: From: Brandon Casey The "it" string would not be free'ed if base_name was non-NULL. Let's free it. Signed-off-by: Brandon Casey --- builtin/mv.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/builtin/mv.c b/builtin/mv.c index e9d191f..5efe6c5 100644 --- a/builtin/mv.c +++ b/builtin/mv.c @@ -29,7 +29,11 @@ static const char **copy_pathspec(const char *prefix, const char **pathspec, to_copy--; if (to_copy != length || base_name) { char *it = xmemdupz(result[i], to_copy); - result[i] = base_name ? xstrdup(basename(it)) : it; + if (base_name) { + result[i] = xstrdup(basename(it)); + free(it); + } else + result[i] = it; } } return get_pathspec(prefix, result); -- 1.7.7