From: Vanak, Ibrahim <ibrahim.vanak@hpe.com>
Date: Wed, 29 May 2019 09:06:18 GMT
Subject: RE: GIT issue while cloning (fatal: pack is corrupted (SHA1 mismatch)) !!!
Message-ID: <TU4PR8401MB1216339F1E7A378C45DF9B36E11F0@TU4PR8401MB1216.NAMPRD84.PROD.OUTLOOK.COM>
In-Reply-To: <TU4PR8401MB12166DBE2156683ADF28E9A4E11F0@TU4PR8401MB1216.NAMPRD84.PROD.OUTLOOK.COM>

Hello Jeff,

Just sharing more information with you on this issue:

After cloning when I tried to checkout a branch on HPUX and Linux, I still significant time difference there as well even though network is not involve here. Do you suspect anything with HPUX OS? Do you have any mechanism to find out who is the causing gigantic delay ?

========================================
Checkout of a branch on HPUX as below
========================================
root@fiend6.in.rdlabs.hpecorp.net# time git checkout remotes/origin/11.23/sfm_1123_main
Checking out files: 100% (12949/12949), done.
Note: checking out 'remotes/origin/11.23/sfm_1123_main'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 39b6110f Commiting to isvn for WEB1303_1123 SFM release

real    8m17.234s
user    0m7.070s
sys     0m1.960s

==============================================
Checkout of the same branch on Linux as below:
==============================================
[root@chandana SysFaultMgmt]# time git checkout remotes/origin/11.23/sfm_1123_main
Checking out files: 100% (12949/12949), done.
Note: checking out 'remotes/origin/11.23/sfm_1123_main'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 39b6110... Commiting to isvn for WEB1303_1123 SFM release

real    0m4.709s
user    0m3.539s
sys     0m1.098s
[root@chandana SysFaultMgmt]#

-----Original Message-----
From: Vanak, Ibrahim 
Sent: Wednesday, May 29, 2019 10:59 AM
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: RE: GIT issue while cloning (fatal: pack is corrupted (SHA1 mismatch)) !!!

Hello Jeff,

Thanks again for the response. 

I am not building GIT and also don't know either how to build. I am just pulling up the binaries from http://hpux.connect.org.uk/. 

Both HPUX and linux machine are in same network/subnet so network shouldn't be a problem here. ssh to HPUX box is super quick and box is having very high configuration. There is no NFS involved here.

I am surprised on slowness.... If you get a chance to look more into this, please.

Thanks & Regards,
Ibrahim Vanak

-----Original Message-----
From: Jeff King [mailto:peff@peff.net]
Sent: Wednesday, May 29, 2019 3:00 AM
To: Vanak, Ibrahim <ibrahim.vanak@hpe.com>
Cc: git@vger.kernel.org
Subject: Re: GIT issue while cloning (fatal: pack is corrupted (SHA1 mismatch)) !!!

On Tue, May 28, 2019 at 06:45:18PM +0000, Vanak, Ibrahim wrote:

> BUT still I have significant slowness(50 times slower than clone on 
> linux machine) while cloning. HPUX box is having very good H/W 
> configuration and network is also stable.

From your output:

> [hpux]
> Receiving objects: 100% (63627/63627), 681.90 MiB | 111.00 KiB/s, done.
> [linux]
> Receiving objects: 100% (63627/63627), 681.90 MiB | 5.59 MiB/s, done.

The main things going on there are:

  1. we're getting the bytes over the network

  2. we're computing a sha1 on the stream we're getting

  3. we're zlib inflating any non-delta objects we find and computing
     their sha1

  4. we're checking the filesystem to see if we have other copies of any
     of those objects

For (2) and (3) it could be that the sha1 implementation is not quite as fast. But 50x is much larger than I'd expect. If you've built Git from source, you could try running "t/helper/test-sha1 <big-file" and timing the result. That would isolate sha1 performance.  If it's slow, try building with "make BLK_SHA1=Yes" or "make OPENSSL_SHA1=Yes" and see if that's faster.

For (4), we'll have to stat() in .git/objects to see if we have a loose version of the object. That can be slow if you have a really terrible NFS setup, for example. But I doubt that would still be slow in v2.21.
There we should be using the new loose-cache which will only readdir() the object directories once.

If neither of those pan out, it seems like the network is slow? Or maybe ssh? Or pipes passing data from clone to index-pack?

-Peff