From: Jiamu Sun <39@barroit.sh> Date: Wed, 29 Apr 2026 05:13:07 GMT Subject: Re: [PATCH] parse-options: fix sparse 'plain integer as NULL pointer' Message-ID: In-Reply-To: On Sun, Apr 26, 2026 at 02:14:03PM +0200, Johannes Schindelin wrote: > Indeed. With this patch on top of Ramsay's fixup, it passes the build: > > Assisted-by: Claude Opus 4.6 > Signed-off-by: Johannes Schindelin > --- > parse-options.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/parse-options.c b/parse-options.c > index 14f3f385eb4..0ba6905fed5 100644 > --- a/parse-options.c > +++ b/parse-options.c > @@ -648,7 +648,8 @@ static const char *autocorrect_subcommand(const char *cmd, > struct string_list *cmds) > { > struct autocorrect autocorrect = { 0 }; > - unsigned int n = 0, best = 0; > + unsigned int n = 0; > + intptr_t best = 0; > struct string_list_item *cand; > > autocorrect_resolve(&autocorrect); > -- snap -- > > > > Ramsay Jones > > > > > > parse-options.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/parse-options.c b/parse-options.c > > > index d60e7bd3c9..14f3f385eb 100644 > > > --- a/parse-options.c > > > +++ b/parse-options.c > > > @@ -658,7 +658,7 @@ static const char *autocorrect_subcommand(const char *cmd, > > > > > > for_each_string_list_item(cand, cmds) { > > > if (starts_with(cand->string, cmd)) { > > > - cand->util = 0; > > > + cand->util = NULL; > > > } else { > > > int edit = levenshtein(cmd, cand->string, > > > 0, 2, 1, 3) + 1; > > > -- > > > 2.54.0 Will squash these in next re-roll. Thanks everyone for catching these issues and providing the fixups. -- Jiamu Sun <39@barroit.sh>