From: Jiamu Sun <39@barroit.sh>
Date: Sun, 08 Mar 2026 22:07:17 GMT
Subject: Re: [PATCH 0/5] parseopt: add subcommand autocorrection
Message-ID: <SY0P300MB080125A3AD82CEF7341D0863CE78A@SY0P300MB0801.AUSP300.PROD.OUTLOOK.COM>
In-Reply-To: <xmqqo6ky9j4l.fsf@gitster.g>

On Sun, Mar 08, 2026 at 01:11:22PM -0700, Junio C Hamano wrote:
> Jiamu Sun <39@barroit.sh> writes:
> 
> > So, this series introduces subcommand auto-correction.
> >
> > Currently, builtins with mandatory subcommands enable autocorrection by
> > default. However, those using PARSE_OPT_SUBCOMMAND_OPTIONAL skip it to
> > avoid treating valid unknown arguments as mistyped subcommands.
> 
> This is a bit confusing as it describes the behavior introduced by
> this series rather than the state of the codebase before these
> patches.  Since subcommand autocorrection doesn't exist yet, it
> would be clearer to phrase this as describing your implementation
> choices. Perhaps:
> 
>     By default, this implementation enables autocorrection for
>     builtins with mandatory subcommands. However, for those using
>     PARSE_OPT_SUBCOMMAND_OPTIONAL, autocorrection is skipped to
>     avoid misinterpreting legitimate unknown arguments as mistyped
>     subcommands.
> 
> or something, perhaps?

Right, that's confusing. By "currently", I meant "in this patch".

Will reword the cover letter in v2 to use your phrasing. Thanks!

-- 
Jiamu Sun <39@barroit.sh>