From: malc Date: Fri, 23 Jan 2009 19:53:31 GMT Subject: Re: [PATCH] Change octal literals to be XEmacs friendly Message-ID: In-Reply-To: <7vbpty1m1r.fsf@gitster.siamese.dyndns.org> On Fri, 23 Jan 2009, Junio C Hamano wrote: > malc@pulsesoft.com writes: > >> case uses eql and (eql ?\001 1) evaluates to nil under XEmacs >> (probably because some internal type of ?\001 is char) > > And I presume the new way to spell is compatible with non XEmacs emacs? > It may be obvious to you, but please spell it out. Parenthesized > "probably" does not help building the confidence in the patch either. Fair enough. XEmacs: (type-of ?\1) yields character FSF Emacs: (type-of ?\1) yields integer > >> Signed-off-by: Vassili Karpov > > How are the (nameless) author of the patch malc@pulsesoft.com and Vassili > Karpov, the person who signed off, related? Both are my e-mail address used in ~/.gitconfig and ~/.emacs (and used by GNUS which was used to post the message via gmane's nntp interface) respectively. > Next time, please spend a few minutes to see if there are active > developers who are familiar in the area you are touching, and Cc your > patch to ask their input. > > git blame -L562,+29 contrib/emacs/git.el > Okay. > tells me that most of this came from 40f162b (git.el: Display file types > and type changes., 2008-01-06) by Alexandre, so I am Cc'ing him. > [..snip..] -- mailto:av1474@comtv.ru