From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 02 Dec 2007 12:13:07 GMT
Subject: Re: [PATCH 6/6] builtin-commit: Add newline when showing which commit was created
Message-ID: <Pine.LNX.4.64.0712021212490.27959@racer.site>
In-Reply-To: <20071202054030.GA393@coredump.intra.peff.net>

Hi,

On Sun, 2 Dec 2007, Jeff King wrote:

> On Sat, Dec 01, 2007 at 10:41:47PM +0000, Johannes Schindelin wrote:
> 
> > Basically, I ran a test case in which the shell script was different from 
> > the builtin version, and this was the patch that fixed it for me.
> > 
> > Maybe it should have been
> > 
> > 	if (log_tree_commit(&rev, commit))
> > 		printf("\n");
> > 
> > at the end of print_summary() instead.  Can you try if that fixes it for 
> > you?
> 
> No, it doesn't, unless you meant "if (!log_tree_commit(...". Of course,
> I can't get log_tree_commit to return anything but true anyway (either
> log_tree_diff shows something, or since we have set always_show_header,
> we end up calling show_log).
> 
> It would be helpful if you could remember the test case, but perhaps
> that is not an option at this point.

IIRC it was "git commit -m bla".

Hth,
Dscho