From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 12 Nov 2007 20:12:06 GMT
Subject: Re: [PATCH 1/6] builtin-commit: fix author date with --amend --author=<author>
Message-ID: <Pine.LNX.4.64.0711122011540.4362@racer.site>
In-Reply-To: <1194896334.2869.7.camel@hinata.boston.redhat.com>

Hi,

On Mon, 12 Nov 2007, Kristian H?gsberg wrote:

> On Sun, 2007-11-11 at 17:35 +0000, Johannes Schindelin wrote:
> > When amending a commit with a new author, the author date is taken
> > from the original commit.
> 
> The new determine_author_info() should fix this.  There was a problem
> earlier that Junio pointed out and I sent a patch to update
> determine_author_info() to do the right thing for amend commits.  The
> test suite still pass without this patch, and if you look carefully a
> determine_author_info(), you can see it does the right thing:
> 
>   1) Default to getenv for name, email and date
> 
>   2) If a commit has been specified (-c, -C or --amend), we parse the
> author name, email and date from use_message_buffer, which holds the
> commit, overriding the values from getenv.
> 
>   3) If --author has be passed, we parse name and email from the
> argument and override whatever name and email the two previous steps
> came up with.
> 
> Then we add the author line to the commit buffer under construction
> based on these values.
> 
> I suggest we back this patch out.

I agree.

Ciao,
Dscho