From: Johannes Schindelin Date: Tue, 06 Nov 2007 23:36:44 GMT Subject: Re: [PATCH 3/3] pretty=format: Avoid some expensive calculations when not needed Message-ID: In-Reply-To: <4730EB4E.4080903@lsrfire.ath.cx> Hi, On Tue, 6 Nov 2007, René Scharfe wrote: > -char *interp_find_active(const char *orig, > - const struct interp *interps, int ninterps) > +void interp_find_active(const char *orig, struct interp *interps, int ninterps) > { > - char *result = xcalloc(1, ninterps); > char c; > int i; > > + for (i = 0; i < ninterps; i++) > + interps[i].active = 0; > + > [...] Funny. I have the _exact_ same change in my repository. I only forgot to send it, it seems. Ciao, Dscho