From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 05 Nov 2007 10:24:58 GMT
Subject: Re: [PATCH] t7501-commit.sh: Add test case for fixing author in amend commit.
Message-ID: <Pine.LNX.4.64.0711051020330.4362@racer.site>
In-Reply-To: <1194234165-9498-1-git-send-email-krh@redhat.com>

Hi,

On Sun, 4 Nov 2007, Kristian Høgsberg wrote:

> +test_tick
>  
>  test_expect_success 'partial commit that involves removal (3)' '

We usually put the test_tick into the test case.  IOW

	test_expect_success 'message' '
		test_tick &&
		...

>  '
>  
> +oldtick=$GIT_AUTHOR_DATE
> +test_tick
> +
> +author="The Real Author <someguy@his.email.org>"
> +committer="$GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE"
> +
> +test_expect_success 'amend commit to fix author' '

Same here.

BTW: is this committer mangling really necessary? I thought only 
GIT_COMMITTER_DATE was relevant.  And that is easily replaced by

	sed -e "s/^\(committer.* \)[0-9][0-9]*$/\1$GIT_COMMITTER_DATE/"

Ciao,
Dscho