From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 31 Oct 2007 02:42:03 GMT
Subject: Re: [PATCH 3/3] git-rebase--interactive.sh: Make 3-way merge strategies work for -p.
Message-ID: <Pine.LNX.4.64.0710310239100.4362@racer.site>
In-Reply-To: <1193797232-1062-3-git-send-email-B.Steinbrink@gmx.de>

Hi Björn,

On Wed, 31 Oct 2007, Björn Steinbrink wrote:

> +			new_parents=${new_parents# $first_parent}

I wanted to comment that this might not be present in shells other than 
bash, but I see that we rely on that construct already in am, clone, 
commit, filter-branch, merge, pull, rebase, stash and submodule.

So I think it's okay.

The whole series is _very_ nicely done, and appears to me as obviously 
correct.

Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>

Thanks,
Dscho