From: Daniel Barkalow <barkalow@iabervon.org>
Date: Thu, 25 Oct 2007 21:37:07 GMT
Subject: Re: [PATCH 5/6] Do linear-time/space rename logic for exact renames
Message-ID: <Pine.LNX.4.64.0710251722290.7345@iabervon.org>
In-Reply-To: <alpine.LFD.0.999.0710251317020.30120@woody.linux-foundation.org>

On Thu, 25 Oct 2007, Linus Torvalds wrote:

> On Thu, 25 Oct 2007, Daniel Barkalow wrote:
> > 
> > Creating a list of the pointers doesn't work correctly with the grow 
> > implementation, because growing the hash may turn a collision into a 
> > non-collision, at which point items other than the first cannot be found 
> > (since they're listed inside a bucket that's now wrong for them). AFAIK, 
> > resizing a hash table requires being able to figure out what happened with 
> > collisions.
> 
> Nope. 
> 
> The hash algorithm is much smarter than that.

Ah, yes. I was just confused by the comment suggesting the possibility of 
a collision when the only way to have two calls get the same bucket is 
when the key that the library gets is actually identical.

	-Daniel
*This .sig left intentionally blank*