From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 14 Oct 2007 00:57:28 GMT
Subject: Re: [PATCH 01/14] Change git_connect() to return a struct child_process instead of a pid_t.
Message-ID: <Pine.LNX.4.64.0710140156100.25221@racer.site>
In-Reply-To: <1192305984-22594-2-git-send-email-johannes.sixt@telecom.at>

Hi,

On Sat, 13 Oct 2007, Johannes Sixt wrote:

> -int finish_connect(pid_t pid)
> +int finish_connect(struct child_process *conn)
>  {
> -	if (pid == 0)
> +	if (conn == NULL)
>  		return 0;
>  
> -	while (waitpid(pid, NULL, 0) < 0) {
> +	while (waitpid(conn->pid, NULL, 0) < 0) {
>  		if (errno != EINTR)
>  			return -1;

Just for completeness' sake: could you do a free(conn); before return -1;?

Thanks,
Dscho