From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 09 Oct 2007 13:15:51 GMT
Subject: Re: [PATCH] git-config: respect other options after -l, most notably --file
Message-ID: <Pine.LNX.4.64.0710091414590.4174@racer.site>
In-Reply-To: <20071009125024.1259.qmail@d8e601127fe8d0.315fe32.mid.smarden.org>

Hi,

On Tue, 9 Oct 2007, Gerrit Pape wrote:

> @@ -234,6 +235,8 @@ int cmd_config(int argc, const char **argv, const char *prefix)
>  		argv++;
>  	}
>  
> +	if (show_all)
> +		return git_config(show_all_config);
>  	switch (argc) {
>  	case 2:
>  		return get_value(argv[1], NULL);

Shouldn't this somehow check if argc == 1 when show_all is set, and die 
otherwise?

Ciao,
Dscho