From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 26 Sep 2007 19:47:49 GMT
Subject: Re: [PATCH] git-commit --amend: respect grafted parents.
Message-ID: <Pine.LNX.4.64.0709262039250.28395@racer.site>
In-Reply-To: <7vd4w51csv.fsf@gitster.siamese.dyndns.org>

Hi,

On Wed, 26 Sep 2007, Junio C Hamano wrote:

> Johannes Sixt <j.sixt@viscovery.net> writes:
> 
> > Johannes Schindelin schrieb:
> >> The reason why I insist on not putting this into --amend is that I 
> >> think this is not really an amend, but actively a rewrite of the 
> >> merge commit.
> >
> > You have a point here. I'm convinced. Scrap the patch.
> 
> I am slow today.  Since when --amend is not about "a rewrite of commit"?

Technically, you are right, of course.  Commit objects are immutable.  But 
from a _porcelain_ view I maintain that "amending" is about changes _to_ a 
commit.  It is not about redefining the (a) parent.

Ciao,
Dscho