From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 17 Sep 2007 09:29:55 GMT
Subject: Re: [PATCH 3/8] repack -A -d: use --keep-unreachable when repacking
Message-ID: <Pine.LNX.4.64.0709171027400.28586@racer.site>
In-Reply-To: <11900187002882-git-send-email-gitster@pobox.com>

Hi,

On Mon, 17 Sep 2007, Junio C Hamano wrote:

> -USAGE='[-a] [-d] [-f] [-l] [-n] [-q] [--max-pack-size=N] [--window=N] [--window-memory=N] [--depth=N]'
> +USAGE='[-a|-A] [-d] [-f] [-l] [-n] [-q] [--max-pack-size=N] [--window=N] [--window-memory=N] [--depth=N]'

Would "[-a] [-A]" not be better?  In other usage lines, we have the "|" 
for alternative forms of the _same_ option, like "[-m|--merge]".

> +	-A)	all_into_one=t
> +		keep_unreachable=t ;;

Why not "keep_unreachable=--keep-unreachable" and use "$args 
$keep_unreachable" later?

Ciao,
Dscho