From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 09 Sep 2007 00:18:43 GMT
Subject: Re: [PATCH] git-diff: don't squelch the new SHA1 in submodule diffs
Message-ID: <Pine.LNX.4.64.0709090117331.28586@racer.site>
In-Reply-To: <20070908103022.GA15229MdfPADPa@greensroom.kotnet.org>

Hi,

On Sat, 8 Sep 2007, Sven Verdoolaege wrote:

> The code to squelch empty diffs introduced by commit
> fb13227e089f22dc31a3b1624559153821056848 would inadvertently
> populate filespec "two" of a submodule change using the uninitialized
> (null) SHA1, thereby replacing the submodule SHA1 by 0{40} in the output.
> 
> This change teaches diffcore_skip_stat_unmatch to handle
> submodule changes correctly.

Ah, I was wondering... This struck me as odd in msysGit, but I did not 
know if it was a problem I introduced in 4msysgit or not.  Unfortunately, 
I did not have the time to investigate further.

Thanks,
Dscho