From: Johannes Schindelin Date: Fri, 07 Sep 2007 10:12:30 GMT Subject: Re: People unaware of the importance of "git gc"? Message-ID: In-Reply-To: <7vk5r3adlx.fsf@gitster.siamese.dyndns.org> Hi, On Thu, 6 Sep 2007, Junio C Hamano wrote: > Johannes Schindelin writes: > > > On Wed, 5 Sep 2007, Junio C Hamano wrote: > > > >> @@ -20,6 +20,7 @@ static const char builtin_gc_usage[] = "git-gc [--prune] [--aggressive]"; > >> > >> static int pack_refs = 1; > >> static int aggressive_window = -1; > >> +static int gc_auto_threshold = 6700; > > > > Please don't do that. > > > > When you share objects with another git directory, git-gc --auto can > > get rid of the objects when some objects go away in the referenced > > repository. > > I thought the whole point of "gc --auto" was to have something > that does not lose/prune any objects, even the ones that do not > seem to be referenced from anywhere. That is why invocations of > "git gc --auto" do not say --prune as you saw the second patch, > and the repack command "gc --auto" runs is "repack -d -l" > instead of "repack -a -d -l", which means that it does run > git-prune-packed after repacking but not git-prune. > > Maybe I am missing something... No, _I_ missed the fact that no pack is rewritten... Sorry for the line noise, Dscho