From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 06 Sep 2007 16:40:02 GMT
Subject: Re: [PATCH 7/9] Add strbuf_read_path().
Message-ID: <Pine.LNX.4.64.0709061739090.28586@racer.site>
In-Reply-To: <11890382262161-git-send-email-krh@redhat.com>

Hi,

On Wed, 5 Sep 2007, Kristian Høgsberg wrote:

> +extern int strbuf_read_path(struct strbuf *sb, const char *path);

May I suggest renaming this to "strbuf_read_file()"?  I kind of expected a 
function which reads in the absolute path of a file, judging by the 
name...

Ciao,
Dscho