From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 06 Sep 2007 14:05:36 GMT
Subject: Re: [PATCH 6/7] Eradicate yet-another-buffer implementation in buitin-rerere.c
Message-ID: <Pine.LNX.4.64.0709061504521.28586@racer.site>
In-Reply-To: <11890776112641-git-send-email-madcoder@debian.org>

Hi,

On Thu, 6 Sep 2007, Pierre Habouzit wrote:

> Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> ---
>  builtin-rerere.c |   56 +++++++++++++++++------------------------------------
>  1 files changed, 18 insertions(+), 38 deletions(-)

I like that one very much, but ...

>  	FILE *f = fopen(path, "r");
>  	FILE *out;
>  
> +        strbuf_init(&minus);
> +        strbuf_init(&plus);
> +

You used spaces instead of tabs here.

Ciao,
Dscho