From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 04 Sep 2007 13:45:21 GMT
Subject: Re: [PATCH] Functions for updating refs.
Message-ID: <Pine.LNX.4.64.0709041444070.28586@racer.site>
In-Reply-To: <46DD6020.4050401@gmail.com>

Hi,

On Tue, 4 Sep 2007, Carlos Rica wrote:

> Signed-off-by: Carlos Rica <jasampler@gmail.com>
> ---
> 
>    They are designed to be reused also from other builtins,
>    like the recently changed builtin-tag.c and the upcoming
>    builtin-reset.c, and perhaps also from builtin-fetch--tool.c.

This should go into the commit message.

> +int update_ref_or_die(const char *action, const char *refname,
> +				const unsigned char *sha1,
> +				const unsigned char *oldval, int flags)

Should this not be "void"?  And should it not use update_ref_or_error()?

Otherwise I like it.

Ciao,
Dscho