From: Johannes Schindelin Date: Mon, 03 Sep 2007 18:35:44 GMT Subject: Re: [PATCH 1/3] Export format_commit_message() Message-ID: In-Reply-To: <46DC4D2C.8070109@lsrfire.ath.cx> Hi, On Mon, 3 Sep 2007, Ren? Scharfe wrote: > -static long format_commit_message(const struct commit *commit, > - const char *msg, char **buf_p, unsigned long *space_p) > +long format_commit_message(const struct commit *commit, const void *template, > + char **buf_p, unsigned long *space_p) I am quite sure that this breaks compilation in C++. Besides, "format" is so much more descriptive here IMHO. What is so wrong with "format" for you? Ciao, Dscho