From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 02 Sep 2007 14:20:52 GMT
Subject: Re: [PATCH] rebase--interactive: do not use one-or-more (\+) in sed.
Message-ID: <Pine.LNX.4.64.0709021518260.28586@racer.site>
In-Reply-To: <46DABD15.4030208@fs.ei.tum.de>

Hi,

On Sun, 2 Sep 2007, Simon 'corecode' Schubert wrote:

> Junio C Hamano wrote:
> > > Just for the record: I believe that \{1,\} might be portable.
> > 
> > Yeah, I obviously looked at the page I quoted that describes
> > what's in and what's not in BRE definition ;-)
> > 
> > But in practice, I do not recall ever seeing an older sed that
> > did not understand one-or-more \+ *and* understood \{1,\}.  Do
> > you?
> 
> Yes, BSD sed (at least DragonFly's, so probably as well FreeBSD-4 (dunno
> about later)):
> 
> chlamydia % echo 5ab123x | sed -e 's/[a-z]\+/AAA/' 
> 5ab123x
> chlamydia % echo 5ab123x | sed -e 's/[a-z]\{1,\}/AAA/' 
> 5AAA123x
> chlamydia % echo 5ab123x | sed -E -e 's/[a-z]+/AAA/' 
> 5AAA123x

Thank you for a proper argument.  I usually ignore hand-waving POSIX 
arguments, but a real-world case changes the situation.

Ciao,
Dscho