From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 26 Jul 2007 03:31:54 GMT
Subject: Re: [Bradford C. Smith] [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar()
Message-ID: <Pine.LNX.4.64.0707260431240.14781@racer.site>
In-Reply-To: <7v7ioocatt.fsf@assigned-by-dhcp.cox.net>

Hi,

On Wed, 25 Jul 2007, Junio C Hamano wrote:

>     From: "Bradford C. Smith" <bradford.carl.smith@gmail.com>
>     Subject: [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar()
>     Date: Wed, 25 Jul 2007 12:49:53 -0400
>     Message-Id: <11853821962210-git-send-email-bradford.carl.smith@gmail.com>
> 
>     Changed git_commit_set_multivar() to use the routines provided by
>     lockfile.c to reduce code duplication and ensure consistent behavior.
> 
>     Signed-off-by: "Bradford C. Smith" <bradford.carl.smith@gmail.com>
> 
> Dscho, I think this is worth doing regardless of that "symlinked
> config" issue.  I haven't followed the code closely enough,
> though.
> 
> What do you think?

I think that I will review it tomorrow; this darned work-tree stuff took 
way longer than expected.

Ciao,
Dscho