From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 18 Jul 2007 14:05:14 GMT
Subject: Re: [PATCH] filter-branch: get rid of "set -e"
Message-ID: <Pine.LNX.4.64.0707181503500.14781@racer.site>
In-Reply-To: <86vechj0zz.fsf@lola.quinscape.zz>

Hi,

[please Cc me]

On Wed, 18 Jul 2007, David Kastrup wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > It was reported by Alex Riesen that "set -e" can break something as 
> > trivial as "unset CDPATH" in bash.
> 
> Not in bash.  Just tried it.  But there are Bourne shells that do get
> annoyed.

The mail I was replying to _explicitely_ stated that it _was_ with bash.  
Not your version of it, but some version.

> > So get rid of "set -e".
> 
> I'd rather write
> 
> [ "X$CDPATH" = "X" ] || unset CDPATH

We would write that as "test", not "[".

But it is much cleaner to get rid of "set -e" anyway.

Ciao,
Dscho