From: Johannes Schindelin Date: Sat, 07 Jul 2007 19:39:10 GMT Subject: Re: [PATCH] path-list.c: always free strdup'ed paths Message-ID: In-Reply-To: <468FEC54.307@lsrfire.ath.cx> Hi, On Sat, 7 Jul 2007, Ren? Scharfe wrote: > Always free .paths if .strdup_paths is set, no matter if the > parameter free_items is set or not, plugging a minor memory leak. > And to clarify the meaning of the flag, rename it to free_util, > since it now only affects the freeing of the .util field. The rational was that it might very well be possible that the pointers you hand to the path_list are already strdup()ed. So you do not set strdup_paths, but you want them free()d. The .util field is in many cases something that is not trivially free()d, but has to call a type-specific function, such as path_list_clear() itself. So I'm mildly negative about your patch. Ciao, Dscho