From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 02 Jul 2007 16:11:11 GMT
Subject: Re: [RFC] Update on builtin-commit
Message-ID: <Pine.LNX.4.64.0707021709120.4071@racer.site>
In-Reply-To: <11833861634103-git-send-email-krh@redhat.com>

Hi,

just a quick comment on the option parser:

On most platforms, sizeof(void*)>=sizeof(int). But I would not rely on 
that. Rather (also because it is prettier), I'd use "union".

Besides, your option parser loses order information, correct? IOW, 
something like "--color --no-color --color" would confuse it.

Ciao,
Dscho