From: Julian Phillips Date: Sun, 01 Jul 2007 05:48:37 GMT Subject: Re: Non-http dumb protocols Message-ID: In-Reply-To: <7vbqewakz8.fsf@assigned-by-dhcp.cox.net> On Sat, 30 Jun 2007, Junio C Hamano wrote: > Daniel Barkalow writes: > >> Do we actually support local-fetch and ssh-fetch/ssh-push any more? They >> seem to me to have been entirely supplanted with respect to functionality >> for a long time now, but the programs are still there. This complicates >> http-fetch, because only one -fetch can be linked into a binary as >> currently designed, and we may want to make http-fetch builtin at some >> point. Can we remove the other dumb protocols and merge fetch.c into >> http-fetch.c? > To be linked with the rest of git, I think the global symbols > fetch.c has are named a little too generically, and they would > need to be fixed first. It may make sense to do the "backend > descriptor" code restructure first _before_ linking anything > with the rest of git. We can rename main() in *-fetch.c to > cmd_*_fetch() only for the ones that we choose to make built-in > when the conversion is ready. > > Having said that, I have a feeling that many people do not build > any of the commit walkers, and especially the http walker, > because they have no need for dumb protocols, and libcurl-dev is > just another piece of dependency they do not have to have. If > we were to do a built-in http-fetch, we also need to make sure > it is done in such a way that people can choose to configure it > out. As part of making fetch a builtin, I also made http-fetch a builtin so that I reuse some of the code. When I did this it kept the same optional build status as the original separate program. Since Daniel based his work on mine, he should have this change too ... however I didn't do any renaming of symbols in builtin-http-fetch.c other than the minimum necessary to make it a builtin. -- Julian --- Taxes are going up so fast, the government is likely to price itself out of the market.