From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 27 Jun 2007 10:33:22 GMT
Subject: Re: [PATCH 1/3] rebase -i: several cleanups
Message-ID: <Pine.LNX.4.64.0706271130020.4438@racer.site>
In-Reply-To: <7vodj2tazk.fsf@assigned-by-dhcp.pobox.com>

Hi,

On Tue, 26 Jun 2007, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >> > +die_abort () {
> >> > +	rm -rf "$DOTEST" 2> /dev/null
> >> > +	die "$1"
> >> > +}
> >> 
> >> Why "2>/dev/null" here?
> >
> > Just to be sure. If it does not exist, it's no error. No sense alarming 
> > the user.
> 
> Yeah, but isn't that exactly why you have "-f" there?  On the
> other hand, if $DOTEST exists but for some reason couldn't be
> removed, we probably would want to know about it.
> 
>     $ rm -fr no-such
>     $ mkdir no-such
>     $ echo >no-such/file
>     $ rm -fr no-such
>     $ mkdir no-such
>     $ echo >no-such/file
>     $ chmod a-w no-such
>     $ rm -fr no-such
>     rm: cannot remove `no-such/file': Permission denied

Good point.

Okay, let's leave the 2> /dev/null out.

Ciao,
Dscho