From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 10 Jun 2007 08:38:55 GMT
Subject: Re: [PATCH 11/21] Rewrite error messages; fix up line lengths
Message-ID: <Pine.LNX.4.64.0706100933270.4059@racer.site>
In-Reply-To: <200706090217.17795.johan@herland.net>

Hi,

On Sat, 9 Jun 2007, Johan Herland wrote:

> Also update selftests to reflect new error messages.

Had you split the patch conceptually, the changes to the tests would have 
been included where appropriate.

I consider a patch _breaking_ a test case, with a follow up patch to the 
test case, a _bug_.

And I consider a change in error messages not good, _unless_ the changes 
have a real value in practice. Which I maintain they do not, in this 
patch-series' case.

Ciao,
Dscho