From: Johannes Schindelin Date: Sun, 10 Jun 2007 08:38:47 GMT Subject: Re: [PATCH 10/21] Free mktag's buffer before dying Message-ID: In-Reply-To: <200706090216.41856.johan@herland.net> Hi, On Sat, 9 Jun 2007, Johan Herland wrote: How does this: > - usage("git-mktag < signaturefile"); > + usage("git-mktag < tag_data_file"); and this: > - relate with your commit message? You might understand that people _could_ get the impression that the patches were not very carefully crafted. Or even worse, the impression, that it was tried to slip some changes by, with a totally unrelated "official" purpose. (Again, reminds me of politics: it's like slipping an intrusive privacy law into an agriculture related law at the 11th hour, just before Christmas, when people do not really pay attention.) Ciao, Dscho