From: Johannes Schindelin Date: Sun, 10 Jun 2007 07:54:32 GMT Subject: Re: [PATCH 1/7] Softrefs: Add softrefs header file with API documentation Message-ID: In-Reply-To: <7vzm389rvl.fsf@assigned-by-dhcp.cox.net> Hi, On Sun, 10 Jun 2007, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Besides, your lines are way too long. Yes, it is not in > > Documentation/SubmittingPatches,... > > ... since you have to read the source to get acquainted > > with it _anyway_, it would only be a duplication to have it in > > SubmittingPatches, too. > > Well, maybe we should do this. > > [...] But where to stop? Many people want to put an opening curly bracket in its own line. Other indenting is subject for discussion, too. White space after operators, but not after function names should be included, too. I know you mean good, but I think it is not a bad idea to let people get familiar with the code (and the formatting rules) first. This way we can even tell who did, and who did not do that, before submitting a patch. Ciao, Dscho