From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 10 Jun 2007 07:49:35 GMT
Subject: Re: [PATCH 04/21] Refactor verification of "tagger" line to be more similar to verification of "type" and "tagger" lines
Message-ID: <Pine.LNX.4.64.0706100846250.4059@racer.site>
In-Reply-To: <7vr6olf1m7.fsf@assigned-by-dhcp.cox.net>

Hi,

On Sat, 9 Jun 2007, Junio C Hamano wrote:

> Johan Herland <johan@herland.net> writes:
> 
> > +	if (!tag_line++)
> >  		return error("char" PD_FMT ": could not find next \"\\n\"", type_line - data);
> > -	tag_line++;

BTW if you _are_ verbosing the output, you might just as well make it 
useful.

The common format is "filename:line[:column]:message", not "char[n]", 
which is a misnomer to begin with, since you are talking about an offset, 
not a char (remember, characters are those things that are displayed in 
place for a given number, so I fully expected char32 to be a space).

Ciao,
Dscho