From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun, 15 Apr 2007 01:41:59 GMT
Subject: Re: [PATCH 2/2] Define a few built-in attribute rules.
Message-ID: <Pine.LNX.4.64.0704141839030.5473@woody.linux-foundation.org>
In-Reply-To: <7vvefy5tzo.fsf@assigned-by-dhcp.cox.net>



On Sat, 14 Apr 2007, Junio C Hamano wrote:
>
> This adds an obviously sane pair of default attribute rules as built-ins.

I'm not sure.

> +	"[attr]binary !diff !crlf",
> +	"* diff crlf",

Why would 

	* diff crlf

be "obviously sane"?

In fact, I'd call it obviously insane.

We do *not* want to default crlf to all files. We want the default to be 
"automatic crlf depending on content". 

Then, on top of that, you can *explicitly* specify crlf or !crlf on some 
particular filename pattern bases.

(Side thought - I have to concur with whoever suggested "-" instead of 
"!". It just reads better, I think)

		Linus