From: Linus Torvalds Date: Thu, 05 Apr 2007 15:34:56 GMT Subject: Re: [PATCH] git-{repack,pack-objects} accept --{pack,blob}-limit to control pack size Message-ID: In-Reply-To: <20070405065433.GD5436@spearce.org> On Thu, 5 Apr 2007, Shawn O. Pearce wrote: > > For glibc we do try to set _FILE_OFFSET_BITS to 64 I repeat: that's _broken_. It's in no way portable. It's a glibc horror. It should not be used. It was a quick hack, but the real way to do it is to use "loff_t" and "llseek". But there simply isn't any way to do mmap() or pread() portably outside the 32-bit area. So there are good reasons why we should just limit pack-files to 32-bits on 32-bit architectures. So I think that Dana's approach is just fundamentally correct. Yeah, we should probably have a 64-bit index as a *possibility*, but it simply isn't a replacement for "keep packs under 2GB in size". Linus