From: Linus Torvalds <torvalds@osdl.org>
Date: Sun, 24 Dec 2006 20:14:52 GMT
Subject: Re: [PATCH 2/7] Switch git_mmap to use pread.
Message-ID: <Pine.LNX.4.64.0612241213320.3671@woody.osdl.org>
In-Reply-To: <Pine.LNX.4.63.0612241407250.19693@wbgn013.biozentrum.uni-wuerzburg.de>



On Sun, 24 Dec 2006, Johannes Schindelin wrote:
> 
> I don't think it matters much. The _only_ platform we really use NO_MMAP 
> (other than for testing) is Windows, and AFAICT it does not have pread(), 
> so it is emulated by lseek/read/lseek anyway.

Windows definitely has pread(). It is, of course, possible that Cygwin 
emulates it some other way (including doing a "lseek/read/lseek" 
combination), but pread() should still be better - because maybe some 
future cygwin release ends up using the native interfaces.

		Linus