From: Linus Torvalds <torvalds@osdl.org>
Date: Mon, 23 Oct 2006 20:49:37 GMT
Subject: Re: [PATCH] xdiff/xemit.c (xdl_find_func): Elide trailing white space in a context header.
Message-ID: <Pine.LNX.4.64.0610231347490.3962@g5.osdl.org>
In-Reply-To: <87y7r63hq6.fsf@rho.meyering.net>



On Mon, 23 Oct 2006, Jim Meyering wrote:
>
> This removes trailing blanks from git-generated diff headers
> the same way a similar patch did that for GNU diff:

NO!

This is _wrong_

You should only remove the space IF IT IS THE ONLY THING ON THE WHOLE 
LINE!

You must not remove white-space in general.

So the patch should check something like

	if (len == 1 && rec[0] == ' ')
		len = 0;

and not like you did it.

Otherwise the patch will simply not even _apply_.

		Linus