From: Linus Torvalds Date: Sat, 02 Sep 2006 17:43:52 GMT Subject: Re: [PATCH] pack-objects: re-validate data we copy from elsewhere. Message-ID: In-Reply-To: <7vwt8m1u6b.fsf@assigned-by-dhcp.cox.net> On Sat, 2 Sep 2006, Junio C Hamano wrote: > > The Linus's theory goes like this: > > (1) A bit in an existing pack was damaged somehow. It might have > happened on the mothership machine when it was first created, > or after it was read and copied to the notebook via rsync. NOTE! With the new loose object format, this will be true even of individually packed files (if you set "core.legacyheaders" to false). So checking the SHA1 of the pack-files is insufficient - at least for those loose objects. So revalidating the individual objects will catch that case too, while revalidating the SHA1 of the old pack-files won't. Linus -- VGER BF report: U 0.5