From: Linus Torvalds Date: Sun, 27 Aug 2006 03:30:49 GMT Subject: Re: [PATCH 00/19] gitweb: Remove dependency on external diff and need for temporary files Message-ID: In-Reply-To: <200608252315.57181.jnareb@gmail.com> On Fri, 25 Aug 2006, Jakub Narebski wrote: > > This series of patches (now finished) removes dependency on > external diff (/usr/bin/diff) to produce commitdiff and blobdiff > views, and the need for temporary files. Ok, can we now please fix my final annouyance, which is that gitweb from the very beginning has apparently believed that the "Signed-off-by:" etc lines are not important, and they get stripped away when looking at the "commit-diff". Also, "commit-diff" really should have some minimal authorship information. It's silly to have to go to "commit" and then separately ask for "diff" to see all these very basic things. So I think that "commit-diff" should basically show the equivalent of "git show --pretty", ie author, date, commit message (including sign-offs) and then the diff. No? Linus