From: Nicolas Pitre <nico@cam.org>
Date: Wed, 23 Aug 2006 03:17:24 GMT
Subject: Re: [PATCH] Fix a comparison bug in diff-delta.c
Message-ID: <Pine.LNX.4.64.0608222311060.3683@localhost.localdomain>
In-Reply-To: <1156300368160-git-send-email-madcoder@debian.org>

On Wed, 23 Aug 2006, Pierre Habouzit wrote:

> (1 << i) < hspace is compared in the `int` space rather that in the unsigned one.
> the result will be wrong if hspace is between  0x40000000 and 0x80000000.
> 
> Signed-off-by: Pierre Habouzit <madcoder@debian.org>

Could you use (1u << i) instead of (unsigned)(1 << i) ?  That looks 
prettier to me at least.


Nicolas