From: Nicolas Pitre <nico@cam.org>
Date: Mon, 21 Aug 2006 15:51:55 GMT
Subject: Re: [PATCH] Verify we know how to read a pack before trying to using it.
Message-ID: <Pine.LNX.4.64.0608211148120.3851@localhost.localdomain>
In-Reply-To: <20060821071002.GA26029@spearce.org>

On Mon, 21 Aug 2006, Shawn Pearce wrote:

> If the pack format were to ever change or be extended in the future
> there is no assurance that just because the pack file lives in
> objects/pack and doesn't end in .idx that we can read and decompress
> its contents properly.
> 
> If we encounter what we think is a pack file and it isn't or we don't
> recognize its version then die and suggest to the user that they
> upgrade to a newer version of GIT which can handle that pack file.

There are already 3 other places where the pack header and version are 
validated: see git-grep pack_version_ok *.c output.  Maybe it would be 
best to abstract those tests all in one place.


Nicolas